Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services #36

Merged
merged 7 commits into from
May 25, 2020
Merged

Fix services #36

merged 7 commits into from
May 25, 2020

Conversation

gerard33
Copy link
Member

No description provided.

@gerard33 gerard33 changed the title Update services.yaml Fix services May 25, 2020
@gerard33 gerard33 merged commit fb7da25 into master May 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the gerard33-services branch May 25, 2020 23:01
@rchl
Copy link
Contributor

rchl commented Jan 5, 2021

@gerard33 Can you explain why you've added such checks to open_app and send_command:

        if self._state == STATE_OFF:
            return

?

It should be possible (it is with my TV) to open an app when TV is off. And since send_command is quite low-level, it's also possible to send many commands when TV is off.

@gerard33
Copy link
Member Author

gerard33 commented Jan 9, 2021

I got error messages when sending commands to my TV when it's off, hence the check. My TV is a few years old and non-Android btw, so that could be causing this.

@rchl
Copy link
Contributor

rchl commented Jan 9, 2021

Hmm. Maybe enabling it for android TVs would make sense then?

Someone might want to send a power on command through that API for example (even if there is a higher-level API for that), or might want to turn on the TV with the open_app command (as mentioned before).

gerard33 added a commit that referenced this pull request Jan 10, 2021
gerard33 added a commit that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants